Adding semantic segmentation example #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let add images to S3 bucket |
frankfliu
approved these changes
Jul 2, 2022
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/ai/djl/examples/inference/SemanticSegmentation.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslatorFactory.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
frankfliu
reviewed
Jul 5, 2022
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** Resizes the image based on the shorter edge or maximum edge length. */ | ||
| private class ResizeShort implements Transform { |
There was a problem hiding this comment.
Suggested change
| private class ResizeShort implements Transform { | |
| private static final class ResizeShort implements Transform { |
There was a problem hiding this comment.
The ResizeShort class from the InstanceSegmentationTranslator is not static or final, and by making it static, the shortEdge, maxEdge, rescaledHeight, and rescaledWidth variables must be initialized at the beginning of the file. If I make it static, what values should they be assigned?
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
============================================
- Coverage 72.08% 69.68% -2.41%
- Complexity 5126 5485 +359
============================================
Files 473 524 +51
Lines 21970 24272 +2302
Branches 2351 2640 +289
============================================
+ Hits 15838 16913 +1075
- Misses 4925 6048 +1123
- Partials 1207 1311 +104
Continue to review full report at Codecov.
|
Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Ran ./gradlew fJ and this was the fix
Change-Id: Iec3943455cb58dc0d8644841446cb3d91242bb20
frankfliu
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Adding semantic segmentation example which includes: